ros-controls / ros_controllers

Generic robotic controllers to accompany ros_control
http://wiki.ros.org/ros_control
BSD 3-Clause "New" or "Revised" License
563 stars 524 forks source link

ackermann_steering_controller: wheel_radius #574

Open iliabaranov opened 3 years ago

iliabaranov commented 3 years ago

Hello all,

The documentation http://wiki.ros.org/ackermann_steering_controller states:

wheel_radius (double)
Radius of the wheels. It is expected they all have the same size. The ackermann_steering_controller will attempt to read the value from the URDF if this parameter is not specified.

Any particular reason for this? Tractors (for example) tend to have much smaller steering wheels. But even regular cars can have different wheel sizes. Perhaps this is something I could extend/add to?

Best wishes, Ilia B.

bmagyar commented 3 years ago

happy to incorporate this change, there's no strong reason for even-sized wheels

iliabaranov commented 3 years ago

First attempt here, I welcome feedback :) https://github.com/ros-controls/ros_controllers/pull/575