search

ros-controls / urdf_geometry_parser

6 stars 8 forks source link

Remove tf2 dependency #15

Closed matthew-reynolds closed 4 years ago

matthew-reynolds commented 4 years ago

As @bmagyar mentioned in #10, tf2 is barely used, and we can easily remove the dependency on it to keep things slightly lighter.

matthew-reynolds commented 4 years ago

Forgot to mention it, but since CI doesn't have any tests yet, I ran this through the tests from #13 as a sanity check. They all still pass.

bmagyar commented 4 years ago

Hypot is C++11 by default... Sorry for the trouble, let's switch back to what we used to have, I wouldn't branch for this just yet, especially before the tests PR

matthew-reynolds commented 4 years ago

Oh right, forgot this is kinetic & melodic. No harm done, I learned something new today :)

I'll revert back to std::sqrt and std::pow and then rebase this once #13 is in.

bmagyar commented 4 years ago

Just rebased it

bmagyar commented 4 years ago

Thanks for this!