Add test for methods - Githubissues

ros-controls / urdf_geometry_parser

6 stars 8 forks source link

Add test for methods #7

Closed vincentrou closed 4 years ago

vincentrou commented 7 years ago

fix #5

bmagyar commented 4 years ago

@matthew-reynolds do you have a bit of spare bandwidth to shake this into shape before we go into Noetic?

matthew-reynolds commented 4 years ago

@bmagyar I'm a bit swamped with navigating exams amid all the COVID-19 uncertainty, but I should have some time next week.

A quick scan looks to me like with a little bit of cleanup, and maybe adding a test for getTransformVector(), this is a good simple first test of the main functions. I think that's probably sufficient for now (Definitely better than nothing!) and we can follow-up to add more complex test cases in the future. Does that sound good from your perspective?

bmagyar commented 4 years ago

Absolutely! Since these are mostly tests, adding them to kinetic too should be fine

matthew-reynolds commented 4 years ago

Closing in favour of #13