search

ros-drivers / audio_common

Common code for working with audio in ROS
BSD 3-Clause "New" or "Revised" License
86 stars 152 forks source link

Add timeout to wait_for_server and wait_for_result #203

Closed nakane11 closed 2 years ago

nakane11 commented 2 years ago

Currently sendMsg() does not return when action server does not exist or no result is sent because timeout of wait_for_server() and wait_for_result() is set to zero. Some users want to escape the function even if action cannot be executed. https://github.com/jsk-ros-pkg/jsk_robot/blob/34a129462403878c9b4c9c86c1aa9b38d506c143/jsk_fetch_robot/jsk_fetch_startup/scripts/battery_warning.py#L34 https://github.com/jsk-ros-pkg/jsk_robot/pull/1589#discussion_r967561657

knorth55 commented 2 years ago

please check https://github.com/nakane11/audio_common/pull/1

nakane11 commented 2 years ago

Thank you. I appreciate your correction.