search

ros-drivers / audio_common

Common code for working with audio in ROS
BSD 3-Clause "New" or "Revised" License
86 stars 152 forks source link

Parameter name error #207

Closed weeshal closed 1 year ago

weeshal commented 1 year ago

Referring to this code. The use of tildes in parameter naming in ROS2 is redundant - seems like the code was translated to ROS2 verbatim but these can be removed: this->declare_parameter("~param") => this->declare_parameter("param")

As a workaround I have to include the tilde as part of parameter name in the launch file but I suggest all the ~ are removed from audio_capture.cpp and elsewhere.

knorth55 commented 1 year ago

Thank you! can you make a PR?

weeshal commented 1 year ago

Yes here it is https://github.com/ros-drivers/audio_common/pull/208

knorth55 commented 1 year ago

Thank you! I merged!