[WIP] ros2 humble cmake error fix

ros-drivers / audio_common

Common code for working with audio in ROS

BSD 3-Clause "New" or "Revised" License

86 stars 151 forks source link

[WIP] ros2 humble cmake error fix #212

Open knorth55 opened 1 year ago

peterdavidfagan commented 1 year ago

Hi @knorth55,

Thanks for posting this fix.

I am looking to build the package for ROS rolling. I haven't looked too closely into this bug but I presume the current pr depends on changes you proposed in rosidl_python to be merged first?

knorth55 commented 1 year ago

@peterdavidfagan yes, you are right. im waiting that pr to be merged

https://github.com/ros2/rosidl_python/pull/187

peterdavidfagan commented 1 year ago

Thanks for the confirmation on this @knorth55.

berndpfrommer commented 4 months ago

Why not move SoundMsgs into its own package (sound_play_msgs)? From what I understand that would work around the bug. Having messages in a separate package is recommended practice anyways.

knorth55 commented 4 months ago

I dont want to do so because it cause the loss of backward compatibility. Also, in terms of debian release, it causes a big issue when we have a new package like that at the core of ros package.

In addition, separating msg package is not written in REP, so it should not be forced to any packages.