ros-drivers / audio_common

Common code for working with audio in ROS
BSD 3-Clause "New" or "Revised" License
86 stars 151 forks source link

ros2 branch is not compiling for ROS 2 Humble #232

Closed Noel215 closed 1 year ago

Noel215 commented 1 year ago

This is the error when compiling in ROS 2 Humble:

Starting >>> sound_play
--- stderr: sound_play                                                                      
CMake Error at /opt/ros/humble/share/ament_cmake_python/cmake/ament_python_install_package.cmake:106 (add_custom_target):
  add_custom_target cannot create target
  "ament_cmake_python_symlink_sound_play" because another target with the
  same name already exists.  The existing target is a custom target created
  in source directory
  "/home/user/exchange/alum/my_ws/src/audio_common/sound_play".  See
  documentation for policy CMP0002 for more details.
Call Stack (most recent call first):
  /opt/ros/humble/share/ament_cmake_python/cmake/ament_python_install_package.cmake:39 (_ament_cmake_python_install_package)
  CMakeLists.txt:36 (ament_python_install_package)

CMake Error at /opt/ros/humble/share/ament_cmake_python/cmake/ament_python_install_package.cmake:141 (add_custom_target):
  add_custom_target cannot create target
  "ament_cmake_python_build_sound_play_egg" because another target with the
  same name already exists.  The existing target is a custom target created
  in source directory
  "/home/user/exchange/alum/my_ws/src/audio_common/sound_play".  See
  documentation for policy CMP0002 for more details.
Call Stack (most recent call first):
  /opt/ros/humble/share/ament_cmake_python/cmake/ament_python_install_package.cmake:39 (_ament_cmake_python_install_package)
  CMakeLists.txt:36 (ament_python_install_package)

---
Failed   <<< sound_play [1.17s, exited with code 1]
knorth55 commented 1 year ago

plase check this pr

https://github.com/ros2/rosidl_python/pull/187

Noel215 commented 1 year ago

Good to know!

Then, are you releasing the packages for humble and following distributions after that is merged?

knorth55 commented 1 year ago

Then, are you releasing the packages for humble and following distributions after that is merged?

yes.

Noel215 commented 1 year ago

Perfect!! Thanks :)