Add EXTEND_EXISTING to allow sound_play to install msgs and python pkg

ros-drivers / audio_common

Common code for working with audio in ROS

BSD 3-Clause "New" or "Revised" License

86 stars 152 forks source link

Add EXTEND_EXISTING to allow sound_play to install msgs and python pkg #248

Open rolker opened 7 months ago

rolker commented 7 months ago

This should solve #227 if the relavent PR to ament_cmake is accepted.

This depends on https://github.com/ament/ament_cmake/pull/517 being accepted.

rolker commented 7 months ago

Converted to draft until dependent PR gets accepted.

knorth55 commented 7 months ago

@rolker Thank you so much for the PR! I really appreciate your help, and I'm sorry that I couldn't work on the issue. I hope your PR will be merged soon

rolker commented 7 months ago

No need to be sorry, you did your part by submitting that initial PR yourself. I just pick up from that thread to try to get us all to a solution.

knorth55 commented 5 months ago

@rolker I feel really sad that your PR got closed... https://github.com/ament/ament_cmake/pull/517 😢