search

ros-drivers / axis_camera

Contains basic Python drivers for accessing an Axis camera's MJPG stream. Also provides control for PTZ cameras.
BSD 3-Clause "New" or "Revised" License
52 stars 74 forks source link

Twist input, TF publisher and associated helper files #11

Closed cedricpradalier closed 11 years ago

cedricpradalier commented 11 years ago

See the different commits to pick and choose what is generally relevant.

jack-oquin commented 11 years ago

+1

mikepurvis commented 11 years ago

Looks awesome, thanks Cedric.

cedricpradalier commented 11 years ago

Thanks,

Just be careful that the load_manifest was incorrect in one of the commits for the axis_publish_tf.py file (axis_camera_kf instead of axis_camera). This is also very much tuned on the kingfisher, so if someone has another input, you may want to test further.

We want to use that for visual servoing where speed control makes much more sense that pose-based servoing. And the camera reports continuous state then :) (within my limited test time)

Regards

On Tue, Apr 9, 2013 at 6:31 PM, mikepurvis notifications@github.com wrote:

Looks awesome, thanks Cedric.

— Reply to this email directly or view it on GitHubhttps://github.com/clearpathrobotics/axis_camera/pull/11#issuecomment-16124020 .

Cedric Pradalier

cedricpradalier commented 11 years ago

Hmm,

reading my code for the publish tf part and it definitely needs a bit more polishing, so I'm cleaning a little bit and will commit a better version soon.

Sorry about that.

On Tue, Apr 9, 2013 at 6:44 PM, Cedric Pradalier <cedric.pradalier@gmail.com

wrote:

Thanks,

Just be careful that the load_manifest was incorrect in one of the commits for the axis_publish_tf.py file (axis_camera_kf instead of axis_camera). This is also very much tuned on the kingfisher, so if someone has another input, you may want to test further.

We want to use that for visual servoing where speed control makes much more sense that pose-based servoing. And the camera reports continuous state then :) (within my limited test time)

Regards

On Tue, Apr 9, 2013 at 6:31 PM, mikepurvis notifications@github.comwrote:

Looks awesome, thanks Cedric.

— Reply to this email directly or view it on GitHubhttps://github.com/clearpathrobotics/axis_camera/pull/11#issuecomment-16124020 .

Cedric Pradalier

Cedric Pradalier

mikepurvis commented 11 years ago

Ultimately, TFs should be published via platform-level URDF—that's where we're headed, but per-sensor TF publishers are an acceptable shim in the short term.

On Tue, Apr 9, 2013 at 1:00 PM, Cedric Pradalier notifications@github.comwrote:

Hmm,

reading my code for the publish tf part and it definitely needs a bit more polishing, so I'm cleaning a little bit and will commit a better version soon.

Sorry about that.

On Tue, Apr 9, 2013 at 6:44 PM, Cedric Pradalier < cedric.pradalier@gmail.com

wrote:

Thanks,

Just be careful that the load_manifest was incorrect in one of the commits for the axis_publish_tf.py file (axis_camera_kf instead of axis_camera). This is also very much tuned on the kingfisher, so if someone has another input, you may want to test further.

We want to use that for visual servoing where speed control makes much more sense that pose-based servoing. And the camera reports continuous state then :) (within my limited test time)

Regards

On Tue, Apr 9, 2013 at 6:31 PM, mikepurvis notifications@github.comwrote:

Looks awesome, thanks Cedric.

— Reply to this email directly or view it on GitHub< https://github.com/clearpathrobotics/axis_camera/pull/11#issuecomment-16124020>

.

Cedric Pradalier

Cedric Pradalier

— Reply to this email directly or view it on GitHubhttps://github.com/clearpathrobotics/axis_camera/pull/11#issuecomment-16125783 .

http://uwmike.com

cedricpradalier commented 11 years ago

I agree. Still, given that everybody doen't have the URDF, it is a good option to have the python script.

Anyway, I'm happier with the files now. Should I do another merge request? (Sorry I actually did not use this feature that much before).

Cheers

On Tue, Apr 9, 2013 at 7:11 PM, mikepurvis notifications@github.com wrote:

Ultimately, TFs should be published via platform-level URDF—that's where we're headed, but per-sensor TF publishers are an acceptable shim in the short term.

On Tue, Apr 9, 2013 at 1:00 PM, Cedric Pradalier notifications@github.comwrote:

Hmm,

reading my code for the publish tf part and it definitely needs a bit more polishing, so I'm cleaning a little bit and will commit a better version soon.

Sorry about that.

On Tue, Apr 9, 2013 at 6:44 PM, Cedric Pradalier < cedric.pradalier@gmail.com

wrote:

Thanks,

Just be careful that the load_manifest was incorrect in one of the commits for the axis_publish_tf.py file (axis_camera_kf instead of axis_camera). This is also very much tuned on the kingfisher, so if someone has another input, you may want to test further.

We want to use that for visual servoing where speed control makes much more sense that pose-based servoing. And the camera reports continuous state then :) (within my limited test time)

Regards

On Tue, Apr 9, 2013 at 6:31 PM, mikepurvis notifications@github.comwrote:

Looks awesome, thanks Cedric.

— Reply to this email directly or view it on GitHub<

https://github.com/clearpathrobotics/axis_camera/pull/11#issuecomment-16124020>

.

Cedric Pradalier

Cedric Pradalier

— Reply to this email directly or view it on GitHub< https://github.com/clearpathrobotics/axis_camera/pull/11#issuecomment-16125783>

.

http://uwmike.com

— Reply to this email directly or view it on GitHubhttps://github.com/clearpathrobotics/axis_camera/pull/11#issuecomment-16126357 .

Cedric Pradalier

mikepurvis commented 11 years ago

Yes please.

On Tue, Apr 9, 2013 at 1:32 PM, Cedric Pradalier notifications@github.comwrote:

I agree. Still, given that everybody doen't have the URDF, it is a good option to have the python script.

Anyway, I'm happier with the files now. Should I do another merge request? (Sorry I actually did not use this feature that much before).

Cheers

On Tue, Apr 9, 2013 at 7:11 PM, mikepurvis notifications@github.com wrote:

Ultimately, TFs should be published via platform-level URDF—that's where we're headed, but per-sensor TF publishers are an acceptable shim in the short term.

On Tue, Apr 9, 2013 at 1:00 PM, Cedric Pradalier notifications@github.comwrote:

Hmm,

reading my code for the publish tf part and it definitely needs a bit more polishing, so I'm cleaning a little bit and will commit a better version soon.

Sorry about that.

On Tue, Apr 9, 2013 at 6:44 PM, Cedric Pradalier < cedric.pradalier@gmail.com

wrote:

Thanks,

Just be careful that the load_manifest was incorrect in one of the commits for the axis_publish_tf.py file (axis_camera_kf instead of axis_camera). This is also very much tuned on the kingfisher, so if someone has another input, you may want to test further.

We want to use that for visual servoing where speed control makes much more sense that pose-based servoing. And the camera reports continuous state then :) (within my limited test time)

Regards

On Tue, Apr 9, 2013 at 6:31 PM, mikepurvis notifications@github.comwrote:

Looks awesome, thanks Cedric.

— Reply to this email directly or view it on GitHub<

https://github.com/clearpathrobotics/axis_camera/pull/11#issuecomment-16124020>

.

Cedric Pradalier

Cedric Pradalier

— Reply to this email directly or view it on GitHub<

https://github.com/clearpathrobotics/axis_camera/pull/11#issuecomment-16125783>

.

http://uwmike.com

— Reply to this email directly or view it on GitHub< https://github.com/clearpathrobotics/axis_camera/pull/11#issuecomment-16126357>

.

Cedric Pradalier

— Reply to this email directly or view it on GitHubhttps://github.com/clearpathrobotics/axis_camera/pull/11#issuecomment-16127632 .

http://uwmike.com