search

ros-drivers / axis_camera

Contains basic Python drivers for accessing an Axis camera's MJPG stream. Also provides control for PTZ cameras.
BSD 3-Clause "New" or "Revised" License
52 stars 74 forks source link

separate executable scripts factoring out common code into modules #15

Open jack-oquin opened 11 years ago

jack-oquin commented 11 years ago

Make modules in src/ with code common to the various nodes.

Move the nodes themselves into scripts/ (standard location). Each one should just import and then invoke an appropriate module function.

jack-oquin commented 11 years ago

I recommend that the documented node names not end in ".py". The fact that they are written in Python is an implementation detail. Users should not care.

That change (if accepted) should be made with "tick-tock" backwards compatibility. For one release we would support the old names, issuing a deprecation warning if they are invoked. In the following release the old names would be removed.

jack-oquin commented 11 years ago

Having most of the logic in Python modules generally makes it easier to write unit tests (see issue #16).