search

ros-drivers / axis_camera

Contains basic Python drivers for accessing an Axis camera's MJPG stream. Also provides control for PTZ cameras.
BSD 3-Clause "New" or "Revised" License
52 stars 74 forks source link

Added service to update video parameters and caught exception in case of incorrect parameter file #18

Closed cedricpradalier closed 4 years ago

cedricpradalier commented 11 years ago

This was causing a limited FPS at boot-up on the kingfisher, probably because ROS_HOME was not correct and the default name for the camera info could not be found.

Missing the file is now reported but does not prevent video acquisition.

Also the streaming function a printing any exception, but roslaunch kept hiding the output. The exceptions are now caught and sent to logerror.

jack-oquin commented 11 years ago

Opened issue: jack-oquin/camera_info_manager_py#7

I've confirmed that Cedric's problem is a bug, and added unit tests to detect it. Still trying to figure out the best way to fix it.

jack-oquin commented 11 years ago

Opened issue: jack-oquin/camera_info_manager_py#8

The problem with changing the exception name to something more accurate, like CameraInfoNotLoadedError, is that any code that catches the former name will no longer work. Leaving the old name defined would not change the fact that it will never be raised after the new name is released.

Comments and suggestions are welcome.

civerachb-cpr commented 4 years ago

Since this PR is so old I'm closing it without merging. Please feel free to resubmit the PR if any of the changes in here are still desired.