search

ros-drivers / axis_camera

Contains basic Python drivers for accessing an Axis camera's MJPG stream. Also provides control for PTZ cameras.
BSD 3-Clause "New" or "Revised" License
52 stars 74 forks source link

added debug output if login to camera was not successful #22

Closed kalectro closed 10 years ago

kalectro commented 11 years ago

After unpacking the camera and using the axis_ptz node, I did not get a sufficient error message. I found out that the camera sent a 401 HTTP response which means that the authentication did not work. I guess there is a bug somewhere, this pull request proposes a work-around which might not be safe, but works

kalectro commented 11 years ago

now also added dynamic_reconfigure support and avoided a bug

paulmilliken commented 10 years ago

Dynamic reconfigure looks like a good idea to me. Is there a reason why Kalectro's pull request hasn't been accepted yet?

kalectro commented 10 years ago

I guess there is too much else to do. I even think the bug fix is more important

mikepurvis commented 10 years ago

Sorry for the massive delay. My preference is to do my own testing before pulling stuff in, but it's not worth this much delay on others trying to use the driver.

paulmilliken commented 10 years ago

Ok. No worries. Thanks for merging Kalectro's changes. I'm no expert on git so let me know if I'm wrong but would a testing branch be useful as a place where pull requests can go before being subsequently tested and then merged into master?

jack-oquin commented 10 years ago

That is a reasonable option for larger changes or those that look somewhat risky.

Personally, I prefer to merge small fixes or enhancements directly into master, following a brief code review. Otherwise, git tends to generate more branches than I like keeping track of.