search

ros-drivers / flir_ptu

ROS driver for FLIR pan-tilt units
http://wiki.ros.org/flir_ptu_driver
14 stars 35 forks source link

Added D48 compatibility #17

Closed jeff-o closed 2 years ago

jeff-o commented 9 years ago

Added driver changes, scripts, URDF and meshes for an ethernet-connected D48 PTU.

tonybaltovski commented 7 years ago

@TheDash can you review?

FYI @jeff-o

UltronDestroyer commented 7 years ago

There is no way to confirm/deny that this is working currently with their existing firmware as this is over 2 years old. There is no way I can approve this until we get something that either:

  1. simulates a d48 firmware interface and has unit tests which test this code against it
  2. manually test this with a d48, with logs showing that it can read and write and configure and move this using this driver. (preferably a video showing that is being actuated, or kernel logs with success messages).
  3. In addition, gazebo sim should be able to use this model/urdf to demonstrate the similar requirements
  4. lastly, showing that this code works alongside existing d46 modules on the same system with this driver.

Without those I can't say that this code works or will maintain integrity of existing d46 drivers out in the world.

civerachb-cpr commented 2 years ago

Given the age of the PR, I'm going to close it.