ros-drivers / flir_ptu

ROS driver for FLIR pan-tilt units
http://wiki.ros.org/flir_ptu_driver
14 stars 35 forks source link

IMPROVEMENT: distinguish between home() and reset() #30

Open marklewis3000 opened 8 years ago

marklewis3000 commented 8 years ago

In driver.cpp, the home() operation is implemented by sending a RESET ' R 'to the ptu, and waiting up to 30 seconds for the reset's response.

Also, the 'R' command does much more than going to the 0,0 pan/tilt, it also controls the calibration, which is probably not what is expected.

I would be better to rename that PTU::reset().

I suggest the the current PTU::home() command should be deprecated and and a new 'PTU::goHome()' defined to avoid confusion.

A better PTU::goHome() command would be implemented with 'pp0 tp0 '. This should only take a maximum of 6.5 seconds at speed 1000, or the speed could be set to 2000 and do the home even faster.