search

ros-drivers / gscam

ROS Camera driver for GStreamer-based video streams.
136 stars 172 forks source link

Replace build and run depend of opencv2 with opencv3. #29

Open robograffitti opened 7 years ago

robograffitti commented 7 years ago

rosdep install gscam does not work because ros-indigo-opencv2 is deprecated.

Insread, ros-indigo-opencv3 is available, so I replaced opencv2 with opencv3 in package.xml.

jack-oquin commented 7 years ago

To which ROS versions should this apply?

Which are not compatible?

robograffitti commented 7 years ago

Maybe only indigo. I've not tried with any other versions.

Then, also I found the vision_opencv package. Instead of ros-indigo-opencv3, is it better to replace opencv2 with vision_opencv? I'm not sure about these dependency and relations.

jack-oquin commented 7 years ago

The usual ROS recommendation for compatibility with multiple distributions is to depend on cv_bridge.

robograffitti commented 7 years ago

That sounds make sense and I feel cv_bridge is the most popular package in the opencv related packages. Therefore, is it suitable to replace opencv2 with cv_bridge for this PR?

jack-oquin commented 7 years ago

Perhaps, although I am not certain. It would require testing on multiple distros.