search

ros-drivers / gscam

ROS Camera driver for GStreamer-based video streams.
136 stars 172 forks source link

Initialize variable #76

Closed clydemcqueen closed 2 years ago

clydemcqueen commented 2 years ago

I noticed a few intermittent failures while doing some more testing on Rolling and Galactic. I traced it down to an uninitialized variable. I should have caught this earlier. :(

I also added a simple Dockerfile.

Rolling CI is failing, but this is related to https://github.com/ros-tooling/action-ros-ci/issues/722

@wep21 @jbohren can you take a look?

jbohren commented 2 years ago

I should have caught this earlier. :(

Sure, but such issues are expected when there's no real review done. Thanks for following up with this, the change makes sense based on how that flag is being used.