Improve Dockerfile - Githubissues

ros-drivers / gscam

ROS Camera driver for GStreamer-based video streams.

136 stars 172 forks source link

Closed clydemcqueen closed 2 years ago

clydemcqueen commented 2 years ago

use COPY instead of git clone, this provides better support for developer workflows
add .dockerignore to avoid copying IDE artifacts into the docker images
fix usage of the ROS_DISTRO ARG. This appeared to be working before because the upstream osrf image set the ROS_DISTRO env var in the image, but it was confusing.

I re-tested the 'core 4' launch files in Foxy, Galactic and Rolling.

@jbohren @wep21 Sorry for the late PR and extra work.

wep21 commented 2 years ago

@clydemcqueen Thank you for the work! It looks good to me. @jbohren Could you merge this PR if this is acceptable?

wep21 commented 2 years ago

@jbohren friendly ping