search

ros-drivers / gscam

ROS Camera driver for GStreamer-based video streams.
136 stars 172 forks source link

feat: add yuv support #78

Closed wep21 closed 2 years ago

wep21 commented 2 years ago

Signed-off-by: wep21 border_goldenmarket@yahoo.co.jp

wep21 commented 2 years ago

@jbohren @clydemcqueen Could you review this PR? This PR supports yuv image encoding.

clydemcqueen commented 2 years ago

Nice improvement! Looks good to me.

I tested this on Foxy, Galactic and Rolling.

I noticed that the image_encoding parameter is missing from the README. (This is true for ROS1 as well.) Can you add it to the README and list the supported encodings?

Possible future work: it would be nice to have a set of tests that quickly run through the possible encodings and check for output.

wep21 commented 2 years ago

@jbohren friendly ping

wep21 commented 2 years ago

@clydemcqueen I added the parameter description at https://github.com/ros-drivers/gscam/pull/78/commits/e3fc18ccd068057383e9b459792283a7a667ee6b

clydemcqueen commented 2 years ago

@wep21 LGTM++