search

ros-drivers / gscam

ROS Camera driver for GStreamer-based video streams.
136 stars 172 forks source link

feat: add option to use sensor data qos #79

Closed wep21 closed 2 years ago

wep21 commented 2 years ago

Signed-off-by: wep21 border_goldenmarket@yahoo.co.jp

wep21 commented 2 years ago

@jbohren @clydemcqueen Could you review this PR? This PR adds the option to use sensor data qos for camera topic.

clydemcqueen commented 2 years ago

LGTM.

Can you add this parameter to the README?

I was hoping that we could use the new externally-configurable QoS options, but:

  1. the new options are not supported by image_transport, and
  2. the new options are not supported in Foxy.

So for now this simple solution is the best.

I tested this w/ rgb8 (the default) in Foxy, Galactic and Rolling. It should work w/ the jpeg pathway as well.

wep21 commented 2 years ago

Can you add this parameter to the README?

@clydemcqueen I added the description in https://github.com/ros-drivers/gscam/pull/79/commits/496b53bf0973b781472a36c61ebcb4317fcb31d6.

clydemcqueen commented 2 years ago

Great, thanks!

wep21 commented 2 years ago

@jbohren friendly ping