search

ros-drivers / joystick_drivers

ROS drivers for joysticks
http://wiki.ros.org/joystick_drivers
204 stars 290 forks source link

Upgrade to SDL2.0.20 #270

Closed roncapat closed 11 months ago

roncapat commented 11 months ago

Fix #267

roncapat commented 11 months ago

@clalancette I noticed a problem with the sdl2_vendor/sdl2-windows-add-vcruntime.patch patch not being applied after switching to point release 20. I'll do some checks and report.

roncapat commented 11 months ago

Should be fixed now. I warn you that it seems to me that during CI the SDL doesn't get built from sources (it may already be present in Ubuntu packages). Maybe FORCE_BUILD_VENDOR_PKG is not set?

clalancette commented 11 months ago

Maybe FORCE_BUILD_VENDOR_PKG is not set?

Yeah, it is not: https://github.com/ros-drivers/joystick_drivers/blob/ros2/.github/workflows/rolling-build-ci.yaml

The vendoring of this package was mostly meant for Windows; on Linux, we generally have a packaged SDL available (though I guess in this case, it might be too old). One thing we could consider would be to build it if the SDL version is not new enough to have the game controller interface.