search

ros-drivers / joystick_drivers

ROS drivers for joysticks
http://wiki.ros.org/joystick_drivers
206 stars 292 forks source link

Memory corruption for SpaceMouse Pro #80

Closed jpetereit closed 4 years ago

jpetereit commented 9 years ago

The 3Dconnexion SpaceMouse Pro has 15 buttons. It generates messages with button IDs ranging from 0 to 26. However, the buttons array of the Joy message is statically resized to 2, which leads to memory corruption when setting button IDs larger than 1 in line 148.

The easiest fix is to always resize the button array to 27, but maybe there is a more elegant way to determine the actual type or button count of the connected device.

JWhitleyWork commented 4 years ago

Closing due to this issue being very old.