search

ros-drivers / leap_motion

Leap Motion ROS integration
http://wiki.ros.org/leap_motion
40 stars 44 forks source link

Escalate leapros.msg to a ROS standard message #30

Open 130s opened 8 years ago

130s commented 8 years ago

As suggested (I'm not sure by who) on ros wiki page for leap_motion:

:
This information is encompassed in the custom message leap_motion/leapros.msg. In the future standard ROS messages should be used.

I've never proposed ROS message types, but if someone is interested in please go ahead. Would it become like sensor_msgs/Hand?

jack-oquin commented 8 years ago

See: http://wiki.ros.org/common_msgs#Guidelines_for_submitting_to_common_msgs

It need not be added to sensor_msgs, or even to the common_msgs repository. The main requirements are:

130s commented 8 years ago

Thank you for the insight Jack.

If we separate messages and create a new package, should we wait the next ROS??? Ideally I kind of want to see it happen soon but I know API-ABI breaking change should generally happen for the next released distro...

jack-oquin commented 8 years ago

One of the advantages of releasing a separate package in its own repository is that it can be added at any time without breaking existing installations. That's great for gathering community use.

kruusamae commented 8 years ago

I've created a separate ROS driver for Leap Motion Controller where I implemented Hand messages. Any interest in merging (part of) this code or message types? Also, when creating a separate *_msgs package, should it be specific to Leap Motion or human body, i.e., are we talking about leap_msgs or human_msgs?

130s commented 8 years ago

@kruusamae Wow. We should definitely consider merging packages with similar/same purposes. I'm no longer actively using, however, Leapmotion device so it'd be great if you or someone can take the initiative.

Also, when creating a separate *_msgs package, should it be specific to Leap Motion or human body, i.e., are we talking about leap_msgs or human_msgs?

@jack-oquin should be the best person to ask for the thoughts on this.

jack-oquin commented 8 years ago

These are good questions to discuss with the ROS Drivers Special Interest Group.