search

ros-drivers / microstrain_mips

Other
26 stars 111 forks source link

Added support for external GPS input #12

Closed CaptKrasno closed 4 years ago

CaptKrasno commented 5 years ago

Added support for external GPS input by allowing the microstrain_node to subscribe to gps topics. Also added example launch file for use with the ublox_gps ros node.

bsb808 commented 5 years ago

This PR adds important support so that the units can use an external GPS input. I've talked with @CaptKrasno and am confident that the fork has been well tested for the external GPS use case.

I am not using the microstrain devices as frequently at this time, so setting up a test with hardware would take me some time. Can anyone test the fork in the standalone use cases to verify that the modifications are backward compatible?

bsb808 commented 5 years ago

@tonybaltovski Any chance you could give this PR a try with a standalone device to verify that all is well?

tonybaltovski commented 5 years ago

@bsb808 will do once I get some hardware.

CaptKrasno commented 5 years ago

any luck with the testing yet? Is there anything you would like me to do/test/try?

bsb808 commented 5 years ago

Thank you for the nudge.

I don't currently have convenient access to test the proposed changes on hardware. Ideally @tonybaltovski might be able to test and verify reverse compatibility.