Closed tonybaltovski closed 5 years ago
Hi Tony,
Have you compiled it under Kinetic? So far, I haven't needed to have separate distro branches. I think the master branch should work fine under Kinetic.
Let me know if you have problems.
Glad to see you are using GX5's on the UGVs. We've been using them on UGVs and the USVs (eg., kingfisher/heron) with good success.
Brian
On Thu, Apr 12, 2018 at 1:20 PM, Tony Baltovski notifications@github.com wrote:
Hey, could you please do a release for Kinetic?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bsb808/microstrain_3dm_gx5_45/issues/6, or mute the thread https://github.com/notifications/unsubscribe-auth/AIggN2-6kOuCpONnYHByFY1NuPMXp8sfks5tn7cagaJpZM4TSbpj .
I compiled it on kinetic and everything appeared to work correctly under some really quick tests
@bsb808 any chance you would be interested in transferring this to the ros-drivers group? We have been using this more and more. You would still have access to it.
I think that would be great. I haven't been using it as much lately, so it would benefit all if it was more actively maintained.
Would I still have the 'author' credit? Not terribly important, but would be nice ;)
Also, this would give us an opportunity to give it a more general name since it supports a number of the Lord/Microstrain MIP devices now.
Let me know how to proceed.
Brian
The repo would just move to ros-drivers and you would be the author still with will the full commit history. You could continue to be a maintainer, if you want. Renaming would be best for Kinetic since it was never released for it. Maybe even a change license?
Sounds great - let's do it.
I'd be happy to be a maintainer. I do still use the driver for the -45 devices, so happy to contribute.
Any thoughts on a new name - "microstrain_3dm" ?
As for license, does the drivers group have a license they prefer?
Brian
Awesome! @tfoote could you help with getting this moved to ros-drivers?
How about microstrain_mips
? It should work with all microstrain units that have MIPS packets. I think the preferred license is BSD.
Just a friendly poke to get this moved to ros-drivers and have it released for Kinetic
Happy to do it. My impression was that @tonybaltovski was going to lead the effort to make the move?
@tonybaltovski are you going to help with this?
@bsb808 can you transfer the repo to ros-drivers org, please?
@tonybaltovski - I'm happy to, but need some instructions on how to execute the transfer.
@bsb808 does this help: https://help.github.com/articles/transferring-a-repository-owned-by-your-personal-account/
Yes - can I be member of the ros drivers group https://github.com/ros-drivers? I'd still like to be involved and help maintain.
Now that the repository is moved and changes have been integrated - what is the status/plan for running a kinetic/melodic release?
+1 @tonybaltovski
I have compiled and run the driver on kinetic and melodic. Based on minimal testing it seem to work as expected. Anyone experience any issues?
If not, I can add to the the releases to our indexing description.
@wxmerkt Which model of IMU are you using? Could give the current master a run to double check everything works for you still. After that I will release it.
We are running the -25
as far as I recall. I found a missing dependency compiling locally, will PR a fix soon.
We got it to compile and publish data with the -25
(after applying #16). I haven't verified the data itself.
Released ros/rosdistro#21361.
Thank you - could you please also bloom it into melodic?
Of course, ros/rosdistro#21362.
Thank you very much :)
Hey, could you please do a release for Kinetic?