search

ros-drivers / mocap_optitrack

ROS nodes for working with the NaturalPoint Optitrack motion capture setup
99 stars 139 forks source link

Motive1.7+ #7

Closed tonybaltovski closed 9 years ago

tonybaltovski commented 9 years ago

Same PR as #6 just to a different target branch.

codenotes commented 9 years ago

Specific changes to data formatter for Motive 1.7. Will not work with earlier versions of Motive.

tonybaltovski commented 9 years ago

@codenotes, you merged too quickly, I was merging the PoseStamped branch into this. Do you want to merge them yourself or should I open another PR? Have you tested any of these changes yet?

codenotes commented 9 years ago

I am novice with git, so let me know if my practices are not appropriate. I understand the code base, but I am not fluent with being a repository maintainer. Learning as I go.

I merged into the Motive1.7 branch, so that is a somewhat experimental branch (maybe I should call this motive17-devel?). I can merge in the other changes into it when you have them. I can not test anything at moment as I am not near my mocap system.

So, If I understand correctly, I should be able to merge your additional changes into motive17 when you incorporate the PoseStamped mods. Easiest if you just complete it and send a pull request and I will bring these into motive17.

From: Tony Baltovski notifications@github.com<mailto:notifications@github.com> Reply-To: ros-drivers/mocap_optitrack reply@reply.github.com<mailto:reply@reply.github.com> Date: Saturday, December 20, 2014 at 4:03 PM To: ros-drivers/mocap_optitrack mocap_optitrack@noreply.github.com<mailto:mocap_optitrack@noreply.github.com> Cc: Greg Brill gbrill@infusion.com<mailto:gbrill@infusion.com> Subject: Re: [mocap_optitrack] Motive1.7+ (#7)

@codenoteshttps://github.com/codenotes, you merged too quickly, I was merging the PoseStamped branch into this. Do you want to merge yourself? Have you tested any of these changes yet?

— Reply to this email directly or view it on GitHubhttps://github.com/ros-drivers/mocap_optitrack/pull/7#issuecomment-67749608.

This email, along with any attachments, may be considered confidential and/or proprietary. If you have received it in error, you are on notice of its status. Please notify me immediately by reply email and then delete this message from your system. Please do not copy it or use it for any purposes, or disclose its contents to any other person. Thank you for your cooperation.

tonybaltovski commented 9 years ago

I was merging it manually since there were conflicts and you already merged it. Not a bad thing, prompt responses are always good. I've never been a repository maintainer so I wouldn't know. I finished it so I will make the PR. I was just wondering if was tested on another system? Thank you for your correspondence.

codenotes commented 9 years ago

No testing yet. I will try it out when I get back to the lab, but xmas vacation, will be awhile. Meanwhile, I will put a note on the readme that warns everyone it is experimental.

Always happy to correspond. I see you are involved in DIY drones. You may be doing similar work to me…using ROS->PX4 copters in mocap. I am actually testing an indoor gps solution we are developing, the mocap is a baseline.

From: Tony Baltovski notifications@github.com<mailto:notifications@github.com> Reply-To: ros-drivers/mocap_optitrack reply@reply.github.com<mailto:reply@reply.github.com> Date: Saturday, December 20, 2014 at 4:19 PM To: ros-drivers/mocap_optitrack mocap_optitrack@noreply.github.com<mailto:mocap_optitrack@noreply.github.com> Cc: Greg Brill gbrill@infusion.com<mailto:gbrill@infusion.com> Subject: Re: [mocap_optitrack] Motive1.7+ (#7)

I was merging it manually since there were conflicts and you already merged it. Not a bad thing, prompt responses are always good. I've never been a repository maintainer so I wouldn't know. I finished it so I will make the PR. I was just wondering if was tested on another system? Thank you for your correspondence.

— Reply to this email directly or view it on GitHubhttps://github.com/ros-drivers/mocap_optitrack/pull/7#issuecomment-67750156.

This email, along with any attachments, may be considered confidential and/or proprietary. If you have received it in error, you are on notice of its status. Please notify me immediately by reply email and then delete this message from your system. Please do not copy it or use it for any purposes, or disclose its contents to any other person. Thank you for your cooperation.

tonybaltovski commented 9 years ago

I tested on Friday but I was in a rush. I will test again on Monday. Enjoy the vacation!

We are using ROS and APM currently for an indoor quadcopter. Indoor GPS is definitely interesting, especially if it less costly then the mocap.

On Sat, Dec 20, 2014 at 4:25 PM, codenotes notifications@github.com wrote:

No testing yet. I will try it out when I get back to the lab, but xmas vacation, will be awhile. Meanwhile, I will put a note on the readme that warns everyone it is experimental.

Always happy to correspond. I see you are involved in DIY drones. You may be doing similar work to me…using ROS->PX4 copters in mocap. I am actually testing an indoor gps solution we are developing, the mocap is a baseline.

From: Tony Baltovski <notifications@github.com<mailto: notifications@github.com>> Reply-To: ros-drivers/mocap_optitrack <reply@reply.github.com<mailto: reply@reply.github.com>> Date: Saturday, December 20, 2014 at 4:19 PM To: ros-drivers/mocap_optitrack <mocap_optitrack@noreply.github.com mailto:mocap_optitrack@noreply.github.com> Cc: Greg Brill gbrill@infusion.com<mailto:gbrill@infusion.com> Subject: Re: [mocap_optitrack] Motive1.7+ (#7)

I was merging it manually since there were conflicts and you already merged it. Not a bad thing, prompt responses are always good. I've never been a repository maintainer so I wouldn't know. I finished it so I will make the PR. I was just wondering if was tested on another system? Thank you for your correspondence.

— Reply to this email directly or view it on GitHub< https://github.com/ros-drivers/mocap_optitrack/pull/7#issuecomment-67750156>.

This email, along with any attachments, may be considered confidential and/or proprietary. If you have received it in error, you are on notice of its status. Please notify me immediately by reply email and then delete this message from your system. Please do not copy it or use it for any purposes, or disclose its contents to any other person. Thank you for your cooperation.

— Reply to this email directly or view it on GitHub https://github.com/ros-drivers/mocap_optitrack/pull/7#issuecomment-67750313 .