search

ros-drivers / odva_ethernetip

Library implementing ODVA EtherNet/IP (Industrial Protocol).
94 stars 48 forks source link

feat(udp_socket): Optional local_ip #8

Closed reinzor closed 6 years ago

reinzor commented 6 years ago

Optional local ip specification that is used for binding. Default is still 0.0.0.0 so we will not break the API.

Motivation for this pull request is the use of this library in the omron_os32_driver package. The 0.0.0.0 binding prevents using multiple scanners on different interfaces, as described in https://github.com/ros-drivers/omron/issues/12

andreucm commented 6 years ago

Hi reinzor!

Very similar implementation we did 2 months ago here: https://github.com/beta-robots/odva_ethernetip/commit/68f30ecdd046fa061b05984b96bc73cf522dfe57

Just wanted to do PR this week, after extensive testing with a pair of motor drives running simultaneously with RPI of about 20ms. It works fine.

Thanks

Andreu

reinzor commented 6 years ago

Hi @andreucm,

I did look for PR before creating one but I did not inspect all the forks ;). Anyhow, good that we came up with the same implementation :)

mikepurvis commented 6 years ago

Looks great, thanks.

reinzor commented 6 years ago

Can a maintainer make a new release?

mikepurvis commented 6 years ago

Done. Sorry for the exceptionally long delay. As in https://github.com/ros-drivers/omron/pull/14#issuecomment-380842781, this repo is up for adoption if you'd like to make your own releases at a cadence which better suits you. :)

Indigo: https://github.com/ros/rosdistro/pull/17426

Kinetic: https://github.com/ros/rosdistro/pull/17427

Melodic: https://github.com/ros/rosdistro/pull/17428