Use serialnumber in camera names

ros-drivers / openni2_camera

ROS wrapper for openni 2.0

http://wiki.ros.org/openni2_camera

BSD 3-Clause "New" or "Revised" License

58 stars 95 forks source link

Use serialnumber in camera names #101

Closed MatthijsBurgh closed 3 years ago

MatthijsBurgh commented 4 years ago

Fixes #100

MatthijsBurgh commented 3 years ago

@reinzor @awesomebytes who is the best person to review this?

MatthijsBurgh commented 3 years ago

@mikeferguson @130s could you maybe take a look at this?

MatthijsBurgh commented 3 years ago

@130s @mikeferguson

Backwards compatibility is 100%. By using the default (false), the behaviour doesn't change at all.
I have renamed the parameter to serialnumber_as_name. I think this is much clearer.
I don't think there are any changes that should be documented in file you suggested. I do have added it to the launch files (Which I cleaned a bit).

130s commented 3 years ago

And I think this is valuable to backport to prior releases (ROS Melodic, Kinetic). I'm on it now. After that I can release and trigger binary pkg generation.

MatthijsBurgh commented 3 years ago

I think the noetic-devel branch can be used for the Melodic release. I don't know about Kinetic.

130s commented 3 years ago

Let's move the release conversation to https://github.com/ros-drivers/openni2_camera/issues/103