Readd mode arguments to openni2.launch

ros-drivers / openni2_camera

ROS wrapper for openni 2.0

http://wiki.ros.org/openni2_camera

BSD 3-Clause "New" or "Revised" License

56 stars 95 forks source link

Readd mode arguments to openni2.launch #102

Open v-lopez opened 3 years ago

v-lopez commented 3 years ago

These args were lost on https://github.com/ros-drivers/openni2_camera/commit/576b616023175f75028430f47c2f72184cfa4587

Afaik there's no other way to specify at startup the mode, and changing the mode after the node is running via dynamic reconfigure is something that we'd like to avoid.

MatthijsBurgh commented 3 years ago

I think it is good to restore this. I suggest keep the documentation line as well as described in https://github.com/ros-drivers/openni2_camera/commit/576b616023175f75028430f47c2f72184cfa4587#diff-f75072e949914a0b3f6d5ac4c7307380d93396eadd46d0ddf4c9a98fae6f3e83L21-L24

I suggest to update the tf_prefix launch file as well to keep these in sync.

Might be best to rebase and merge into noetic-devel

130s commented 1 year ago

Thank you for the contribution. I took a liberty to change the target branch to ros1, which might have not existed when this PR was opened.

I won't have a room to take a closer look nor test myself. Nor have I time to address the suggestion https://github.com/ros-drivers/openni2_camera/pull/102#issuecomment-762093262. That said, with @MatthijsBurgh comment, I'm inclined to merging (and depend on the OSS community to test). In a few days I might merge unless we'll receive objections.