search

ros-drivers / openni2_camera

ROS wrapper for openni 2.0
http://wiki.ros.org/openni2_camera
BSD 3-Clause "New" or "Revised" License
58 stars 95 forks source link

openni2_driver_lib needs a dependency on GetSerial #43

Closed tfoote closed 8 years ago

tfoote commented 8 years ago

It's failing to build on Xenial 64 due to this: http://build.ros.org/view/Kbin_uX64/job/Kbin_uX64__openni2_camera__ubuntu_xenial_amd64__binary/22/console

23:34:17 /usr/lib/ccache/x86_64-linux-gnu-g++   -DROSCONSOLE_BACKEND_LOG4CXX -DROS_PACKAGE_NAME=\"openni2_camera\" -Dopenni2_driver_lib_EXPORTS -I/tmp/binarydeb/ros-kinetic-openni2-camera-0.2.6/obj-x86_64-linux-gnu/devel/include -I/tmp/binarydeb/ros-kinetic-openni2-camera-0.2.6/include -I/opt/ros/kinetic/include -I/usr/include/openni2  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -DNDEBUG -Wdate-time -D_FORTIFY_SOURCE=2  -fPIC   -o CMakeFiles/openni2_driver_lib.dir/src/openni2_driver.cpp.o -c /tmp/binarydeb/ros-kinetic-openni2-camera-0.2.6/src/openni2_driver.cpp
23:34:21 In file included from /tmp/binarydeb/ros-kinetic-openni2-camera-0.2.6/src/openni2_driver.cpp:32:0:
23:34:21 /tmp/binarydeb/ros-kinetic-openni2-camera-0.2.6/include/openni2_camera/openni2_driver.h:54:38: fatal error: openni2_camera/GetSerial.h: No such file or directory
23:34:21 compilation terminated.

I believe this line needs the additional dependency ${PROJECT_NAME}_generate_messages_cpp

Surprisingly this is the only platform where it is failing due to this race condition.

jacquelinekay commented 8 years ago

It would be if we could fix this ASAP (at least before the next Kinetic sync) since currently neither openni2_camera nor freenect_stack are available for Kinetic. @130s

mikeferguson commented 8 years ago

@jacquelinekay -- if you can open a PR I can get it merged release -- but I don't have compile/test capabilities at the moment

jacquelinekay commented 8 years ago

I think #44 will fix this.

jacquelinekay commented 8 years ago

I think the build is still failing because the fixed version needs a release.

mikeferguson commented 8 years ago

@jacquelinekay I never saw a "build has returned to normal" on the deb, so I forgot to release -- I see http://build.ros.org/job/Kdev__openni2_camera__ubuntu_xenial_amd64/changes -- releasing now

mikeferguson commented 8 years ago

https://github.com/ros/rosdistro/pull/11768