search

ros-drivers / openni2_camera

ROS wrapper for openni 2.0
http://wiki.ros.org/openni2_camera
BSD 3-Clause "New" or "Revised" License
56 stars 96 forks source link

fix compile on kinetic #44

Closed jacquelinekay closed 8 years ago

jacquelinekay commented 8 years ago

Following Tully's suggestion from #43 to fix the Kinetic binary job.

tfoote commented 8 years ago

+1 that looks right to me

jack-oquin commented 8 years ago

Any idea why this problem suddenly started manifesting itself?

jacquelinekay commented 8 years ago

@tfoote thinks that it succeeded previously due to a race condition. I suppose you could check this theory by using -j1.

I'm not so sure myself. I was able to reproduce the failure reliably on Xenial using catkin_tools. (I believe the Kinetic buildfarm uses catkin_make.) It may be related to stricter behavior in the new version of CMake on Xenial.

tfoote commented 8 years ago

@jack-oquin I suspect that the newer versions of make have a slightly different default execution order for targets that are not specified as a dependency. If there are targets A and B and they don't have a dependency between them A or B might go first.

@jacquelinekay it's can be minimized with -j1 but that won't necessarily fix it it defaults to building B then A. With parallel jobs A and B can get built simultaneously so B will never have A's output.

jack-oquin commented 8 years ago

Thanks for the info, that makes sense.

It always bugs me when things start failing (or working) for unknown reasons.

Thanks for the patch!

130s commented 8 years ago

+1

jacquelinekay commented 8 years ago

It seems like this has multiple approvals but I don't have write permissions here, waiting on someone else to merge it.

mikeferguson commented 8 years ago

as soon as the devel job makes it through the farm, I'll do a new release