search

ros-drivers / openni2_camera

ROS wrapper for openni 2.0
http://wiki.ros.org/openni2_camera
BSD 3-Clause "New" or "Revised" License
56 stars 96 forks source link

Add exposure time control #46

Closed taketwo closed 7 years ago

taketwo commented 8 years ago

This pull request adds getter/setter methods for exposure time and a dynamic reconfigure option to manipulate this setting.

taketwo commented 8 years ago

Are there any issues with this patch?

taketwo commented 8 years ago

Hey, this is a very trivial patch. Is there any chance of merging it soon?

130s commented 7 years ago

Do you think of any tests to be added to your PR?

taketwo commented 7 years ago

I do not think so. This PR adds a trivial wrapper around a driver API function, nothing to test.

mikeferguson commented 7 years ago

@taketwo -- not sure how, but I completely missed this PR. I'm not in the office right now to test on hardware, as soon as I get back I will test this. Just looking over it, looks good, but I have a complete set of prime sense devices I test against to make sure certain hardware doesn't cause particular regressions.

taketwo commented 7 years ago

No worries, thanks for taking care. By the way, some Xtions seem to ignore this command. (From my experience, these are devices with serial numbers starting with 12.)

taketwo commented 7 years ago

@mikeferguson Any chance for a new release including this patch?

130s commented 7 years ago

Any chance for a new release including this patch?

Done https://github.com/ros-drivers/openni2_camera/issues/49#issuecomment-325248736 Binary should become available in the next public sync (watch https://discourse.ros.org/c/release if interested).