search

ros-drivers / openni2_camera

ROS wrapper for openni 2.0
http://wiki.ros.org/openni2_camera
BSD 3-Clause "New" or "Revised" License
56 stars 95 forks source link

[CLOSED] Add machine parameter #60

Closed 130s closed 6 years ago

130s commented 6 years ago

Issue by liborw Monday Sep 02, 2013 at 08:08 GMT _Originally opened as https://github.com/ros-drivers/openni2_launch/pull/3_

This pull request will enable to launch openni2 driver on different machine.

_liborw included the following code: https://github.com/ros-drivers/openni2_launch/pull/3/commits_

130s commented 6 years ago

Comment by mikeferguson Thursday Sep 05, 2013 at 03:24 GMT

@liborw -- the manager.launch aspects of this should be sent to rgbd_launch. If you open a pull request on that, as soon as I see it merge I will insert the openni2.launch parts into this codebase (your current PR would become busted when https://github.com/ros-drivers/openni2_launch/pull/4 is merged).

130s commented 6 years ago

Comment by liborw Thursday Sep 05, 2013 at 08:15 GMT

Ok, I was not aware of rgbd_launch.

130s commented 6 years ago

Comment by mikeferguson Thursday Sep 05, 2013 at 16:43 GMT

@liborw not a problem, most of the discussion on rgbd_launch happened on other issue trackers (such as the one for openni2_camera)

130s commented 6 years ago

Comment by mikeferguson Friday Sep 06, 2013 at 20:33 GMT

I've added the components to openni2.launch with this PR https://github.com/ros-drivers/openni2_launch/pull/4.