[CLOSED] Update openni2_launch to be thin wrapper around rgbd_launch

ros-drivers / openni2_camera

ROS wrapper for openni 2.0

http://wiki.ros.org/openni2_camera

BSD 3-Clause "New" or "Revised" License

56 stars 96 forks source link

[CLOSED] Update openni2_launch to be thin wrapper around rgbd_launch #61

Closed 130s closed 6 years ago

130s commented 6 years ago

Issue by mikeferguson Thursday Sep 05, 2013 at 03:15 GMT _Originally opened as https://github.com/ros-drivers/openni2_launch/pull/4_

Should not be merged until this is merged: https://github.com/ros-drivers/rgbd_launch/pull/1

_mikeferguson included the following code: https://github.com/ros-drivers/openni2_launch/pull/4/commits_

130s commented 6 years ago

Comment by mikeferguson Thursday Sep 05, 2013 at 03:20 GMT

@jonbinney @hershwg You are the only people I know for certain were using this (based on commits) -- please let me know if this breaks anything on you, it works for all my usecases. A few changes are:

/camera/rgb/image becomes /camera/rgb/image_raw (to match openni/freenect)
/camera/depth/points_xyzrgb becomes /camera/depth_registered/points (to match openni/freenect)

If I don't hear any complaints in the next few days, I'll merge and push debs.

130s commented 6 years ago

Comment by mikeferguson Thursday Sep 05, 2013 at 03:25 GMT

Also, I will insert a dependency on rgbd_launch when I update the maintainer email before release.

130s commented 6 years ago

Comment by mikeferguson Friday Sep 06, 2013 at 20:32 GMT

Merging this... will push a debian release this afternoon