search

ros-drivers / openni2_camera

ROS wrapper for openni 2.0
http://wiki.ros.org/openni2_camera
BSD 3-Clause "New" or "Revised" License
56 stars 96 forks source link

[CLOSED] enables proper namespacing #63

Closed 130s closed 6 years ago

130s commented 6 years ago

Issue by bit-pirate Monday Sep 16, 2013 at 07:26 GMT _Originally opened as https://github.com/ros-drivers/openni2_launch/pull/6_

This is similar to https://github.com/ros-drivers/openni_launch/issues/2

Is there a specific reason why this hasn't been adopted for openni2_launch or has this just been missed?

_bit-pirate included the following code: https://github.com/ros-drivers/openni2_launch/pull/6/commits_

130s commented 6 years ago

Comment by mikeferguson Monday Sep 16, 2013 at 07:49 GMT

I think this was missed when I moved over to using rgbd_launch. Name should probably be /camera/nodelet_manager, not /camera/camera_nodelet_manager, no?

130s commented 6 years ago

Comment by bit-pirate Monday Sep 16, 2013 at 08:00 GMT

We kept that as it was before as we didn't see any drawbacks nor benefits. This is the same as it is in openni1_launch.

130s commented 6 years ago

Comment by mikeferguson Monday Sep 16, 2013 at 08:01 GMT

ok, lgtm then