ros-drivers / openni2_camera

ROS wrapper for openni 2.0
http://wiki.ros.org/openni2_camera
BSD 3-Clause "New" or "Revised" License
56 stars 96 forks source link

[CI] Add ABI check using industrial_ci. Update for ROS Jade #75

Closed 130s closed 6 years ago

130s commented 6 years ago
130s commented 6 years ago

ABI check fails only for Indigo (it also failed for Jade, but now I turned it off for J).

https://travis-ci.org/ros-drivers/openni2_camera/jobs/315752945#L811

[build] Note: Workspace packages have changed, please re-source setup files to use them.
Detect public symbols
Reading debug-info
Reading v-tables
Creating ABI dump
The object ABI has been dumped to:
  /abicheck/old/indigo-devel/abi_dumps/libopenni2_camera_nodelet.dump
Detect public symbols
Reading debug-info
Reading v-tables
Creating ABI dump
The object ABI has been dumped to:
  /abicheck/old/indigo-devel/abi_dumps/libopenni2_driver_lib.dump
Detect public symbols
Reading debug-info
Reading v-tables
Creating ABI dump
The object ABI has been dumped to:
  /abicheck/old/indigo-devel/abi_dumps/libopenni2_wrapper.dump
<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
Function abi_build_base returned with code '0' after 0 min 40 sec 
abi_check_libopenni2_camera_nodelet
0.11s>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
Preparing, please wait ...
ERROR: no symbols info in the ABI dump
<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
Function abi_check_libopenni2_camera_nodelet returned with code '7' after 0 min 0 sec 

@ipa-mdl sorry to bother you but I'd appreciate if you could share your opinion.

mathias-luedtke commented 6 years ago

Not sure what's going wrong here.. Some oberservations for now:

CMake Warning at /opt/ros/kinetic/share/catkin/cmake/catkin_package.cmake:166 (message): catkin_package() DEPENDS on 'libopenni2' but neither 'libopenni2_INCLUDE_DIRS' nor 'libopenni2_LIBRARIES' is defined. Call Stack (most recent call first): /opt/ros/kinetic/share/catkin/cmake/catkin_package.cmake:102 (_catkin_package) CMakeLists.txt:20 (catkin_package)

mathias-luedtke commented 6 years ago

I have tried it locally and the "SymbolInfo" entry is missing from the dump. Perhaps it does not work with trusty.. Or some dependency is missing..

130s commented 6 years ago

@ipa-mdl thank you for taking a look. Let's keep track of Indigo issue in https://github.com/ros-industrial/industrial_ci/issues/258 For KL the CI passed. Merging.