search

ros-drivers / openni_camera

A ROS driver for OpenNI depth (+ RGB) cameras.
49 stars 60 forks source link

Noetic release request #77

Closed knorth55 closed 2 years ago

knorth55 commented 2 years ago

@130s Thank you for this useful package. Are there any plan to release this package in Noetic? If you have no time, I can help you for noetic release.

130s commented 2 years ago

Thank you for the headsup. Release of 1.6.0 is made on openni2_camera side. .deb generation is requested in https://github.com/ros/rosdistro/pull/32739 Closing for now.

130s commented 2 years ago

I'm sorry https://github.com/ros-drivers/openni_camera/issues/77#issuecomment-1096551058 was about openni2. Re-opening.

@knorth55 If you have verified the functionality of the pkgs on this repo on ROS noetic, wolud you mind opening a PR, had there been any code change needed to get it working? I just made ros1 branch off of indigo-devel, which I intend to use as the main development branch for ROS Melodic and Noetic.

130s commented 2 years ago

@knorth55 On a separate note, I added a maintainer right on this repo. Thank you for stepping up! Feel free to add yourself in package.xml.

knorth55 commented 2 years ago

@130s thank you! I will check for noetic!

knorth55 commented 2 years ago

I checked with the current branch, and it works in Noetic + Kinect. Screenshot from 2022-04-13 22-08-00

knorth55 commented 2 years ago

@130s can you change the default branch from indigo-devel to ros1 and give access to ros-gbp/openni_camera-release? https://github.com/ros-gbp/openni_camera-release

knorth55 commented 2 years ago

Thanks to #67, python3 is already supported.

130s commented 2 years ago

Thank you! Because of the confirmation you made, I don't feel a necessity to cut another version release on this repo. What's needed instead is to publish into a new ROS distro i.e. Noetic, which is requested https://github.com/ros/rosdistro/pull/32783 (using bloom).

can you change the default branch from indigo-devel to ros1 and give access to ros-gbp/openni_camera-release? https://github.com/ros-gbp/openni_camera-release

Done and done.

knorth55 commented 2 years ago

You released the current version in Noetic! Perfect! Thank you!!