search

ros-drivers / openni_tracker

24 stars 45 forks source link

Remove NITE as a system dependency #8

Closed adwilson10 closed 9 years ago

adwilson10 commented 9 years ago

This PR addresses issues #6 and #7 since NITE is technically not allowed to be repackaged anymore. Openni_tracker does not need to be linked to NITE libraries, so having users manually post-install NITE works fine. When NITE is not installed, an error message directs users to the README for download locations. This should also allow release into Indigo which doesn't provide libopenni-nite-dev.

wjwwood commented 9 years ago

@adwilson10 sorry I haven't had time to look at this, the other maintainers are quite busy right now too I believe. But we'll get to it eventually, I just wanted to let you know we hadn't forgotten about this.

bit-pirate commented 9 years ago

Looks good at first glance, but haven't had the chance to test it myself. Will try get myself or someone on the lab to test it soon.

bit-pirate commented 9 years ago

Just checked it. I think this is a good addition!

bit-pirate commented 9 years ago

This should also allow us to release this package for both hydro and indigo. Merging now.

Thanks for the contribution @adwilson10 !