search

ros-drivers / phidgets_drivers

ROS drivers for various Phidgets devices
Other
46 stars 61 forks source link

adding support for analog outputs for ROS2 Foxy #144

Closed AlexisFetet closed 2 years ago

AlexisFetet commented 2 years ago

Adding support for analog outputs on ROS2 Foxy. Adding a force enable option on analog outputs.

Tested on PhidgetAnalog 1002_0B

mintar commented 2 years ago

Please install pre-commit as described in the README:

https://github.com/ros-drivers/phidgets_drivers#pre-commit-formatting-checks

Then run:

pre-commit run -a

This will fix the failing build.

clalancette commented 2 years ago

@mintar My suggestion here is that we actually retarget this PR to the rolling branch, get it reviewed and merged there, and then backport it to Foxy. That's most consistent with how we do development elsewhere; what do you think?

mintar commented 2 years ago

Yes, agreed! This should be retargeted to the rolling branch.

AlexisFetet commented 2 years ago

I will close this PR and recreate a new one directed to rolling with the requested changes to make it cleaner.

mintar commented 2 years ago

You don't have to open a new PR! If you continue using this PR, all the info stays in one place. You can force-push to your branch, and it will automatically update here. And you can select the targeted branch (rolling) in the web interface of GitHub.