ros-drivers / pointgrey_camera_driver

ROS driver for Pt. Grey cameras, based on the official FlyCapture2 SDK.
128 stars 180 forks source link

Framerate defaults to 7Hz or less #10

Closed jeff-o closed 10 years ago

jeff-o commented 10 years ago

The default launch file causes the framerate of the camera to default to 7Hz or less. The solution is to add this param to the launch file:

<param name="frame_rate" type="double" value="30" />

This has been tested with the Bumblebee and FireflyMV cameras.

mikepurvis commented 10 years ago

Is type="double" necessary? Can you create a PR against the bumblebee and camera example launch files, please?

jeff-o commented 10 years ago

Looks like "double" isn't necessary.

Manually specifying the frame rate does the trick, but it looks like the driver attempts to determine the frame rate by itself, or at least set a maximum (line 178 of PointGreyCamera.cpp). Therefore, there's a chance that it is just staying on the default 7.5Hz even though the Bumblebee is capable of more.

mikepurvis commented 10 years ago

Okay, please submit a PR to change it to a more reasonable default.

mikepurvis commented 10 years ago

@jeff-o Did you want to change this for the next release?

jeff-o commented 10 years ago

No need for me to do it; the change is already included in the new launch file RG committed with his changes.


Sent from my Apple ][

On Aug 18, 2014, at 12:15 AM, Mike Purvis notifications@github.com wrote:

@jeff-o Did you want to change this for the next release?

— Reply to this email directly or view it on GitHub.

mikepurvis commented 10 years ago

I don't see frame_rate in either camera.launch or bumblebee.launch. Please confirm that this is as you want it:

https://github.com/ros-drivers/pointgrey_camera_driver/blob/0bd5f9a8aceea1e032f608e15721db75dcb9b361/pointgrey_camera_driver/launch/bumblebee.launch https://github.com/ros-drivers/pointgrey_camera_driver/blob/0bd5f9a8aceea1e032f608e15721db75dcb9b361/pointgrey_camera_driver/launch/camera.launch

jeff-o commented 10 years ago

Huh, weird. Well anyway, I've created a pull request to add a frame_rate parameter to the two launch files.

On Mon, Aug 18, 2014 at 7:32 AM, Mike Purvis notifications@github.com wrote:

I don't see frame_rate in either camera.launch or bumblebee.launch. Please confirm that this is as you want it:

https://github.com/ros-drivers/pointgrey_camera_driver/blob/0bd5f9a8aceea1e032f608e15721db75dcb9b361/pointgrey_camera_driver/launch/bumblebee.launch

https://github.com/ros-drivers/pointgrey_camera_driver/blob/0bd5f9a8aceea1e032f608e15721db75dcb9b361/pointgrey_camera_driver/launch/camera.launch

— Reply to this email directly or view it on GitHub https://github.com/ros-drivers/pointgrey_camera_driver/issues/10#issuecomment-52480577 .

Jeff Schmidt System Integration Technologist Clearpath Robotics Phone: 519-513-2416

mikepurvis commented 10 years ago

Closed via #13