ros-drivers / pointgrey_camera_driver

ROS driver for Pt. Grey cameras, based on the official FlyCapture2 SDK.
128 stars 180 forks source link

Should prevent multiple camera nodes from conflicting. #11

Closed wnoise closed 10 years ago

wnoise commented 10 years ago

Always loading nodelets into the same process gets conflicts. Now each node loads its own copy.

mikepurvis commented 10 years ago

I don't understand the change— is this for the nodelet or the node?

wnoise commented 10 years ago

For the node -- as it works as a nodelet manager and loads the nodelet, it needs a unique name, just as real nodelet managers do. Running two nodes at the same time confuses the nodelet loading code.

Without this, I can't run multiple cameras as nodes, nor as nodelets sharing a single manager, but can as nodelets with separate managers. With this, I can run multiple cameras as nodes and as nodelets with separate managers, but not as nodelets sharing a single manager.

mikepurvis commented 10 years ago

The typical usage model for cameras is as a nodelet, but making the node wrapper slightly friendlier harms nothing. Thanks!