Add multi-release support, bump SDK to 2.11.3.121 for xenial and 2.9.3.43 for trusty

ros-drivers / pointgrey_camera_driver

ROS driver for Pt. Grey cameras, based on the official FlyCapture2 SDK.

128 stars 180 forks source link

Add multi-release support, bump SDK to 2.11.3.121 for xenial and 2.9.3.43 for trusty #127

Closed Baycken closed 6 years ago

Baycken commented 7 years ago

Fixed all catkin lint -W2 errors and warnings. Only significant change is change the how download_flycap is run from cmake: Execution bit of the script is removed and the cmake invoke python to run the script instead of running the script as executable. This is done to resolve warning about not installed executable.
Use cmake magic to choose which version on flycap to use for xenial and trusty thus allow both release to be used.
Bump the SDK version for xenial to 2.3.11.121 and for trusty to 2.3.9.43.

mikepurvis commented 7 years ago

Thanks very much for looking at this— I know there have been a number of reports around 16.04, particularly in #73, a previous PR along similar lines.

It looks like you have a bunch of __cxx11 linker errors (indicating an STL ABI mismatch) occurring in the Travis environment, which is Ubuntu Trusty + GCC 4.8.4. Since we do get a clean build from the buildfarm (running Xenial with GCC 5.3.1), I think our options are:

Drop support for Indigo, at least in the master branch. Either eliminate the Travis job, or switch it to use a containerized Xenial. Create an indigo-devel branch as required to manage further maintenance-only changes targeting Indigo.
Make the build able to detect which STL is present, and download the correct version of FlyCapture, thus maintaining some semblance of Trusty/Indigo support on the master branch.

Thoughts? @konradb3 @ironmig @tedchina

kev-the-dev commented 7 years ago

I'd like to see the indigo compatibility maintained as there are still several years left in indigo support and I'm sure there's a lot of robots out there running indigo with pointgrey cameras still (my lab has at least one). Perhaps create an indigo-devel branch like many big ROS project have adopted and occasionally backport changes if they build (while maintaining this diff in the SDK version of the cmake). What do you think about this?

Baycken commented 6 years ago

I added version selection for Ubuntu releases by using code name, I think this way both indigo/trusty and kinetic/xenial can be supported

Baycken commented 6 years ago

@mikepurvis, how does this look now?

mikepurvis commented 6 years ago

Looks terrific. Thanks for your patience and persistence in getting this through.