search

ros-drivers / pointgrey_camera_driver

ROS driver for Pt. Grey cameras, based on the official FlyCapture2 SDK.
128 stars 180 forks source link

Add frame_rate parameter to launch files. #13

Closed jeff-o closed 10 years ago

jeff-o commented 10 years ago

Helpful if the driver doesn't default to the correct frame rate for your camera.

mikepurvis commented 10 years ago

Should it not be 15 in both cases?

jeff-o commented 10 years ago

Not necessarily. Scanning the list of different cameras from Point Grey, they range in frame rate from 7 all the way to 60. I can confirm that the Bumblebee is set for 15 fps from the factory.

mikepurvis commented 10 years ago

What's the purpose of specifying empty string in the case of camera.launch then? Shouldn't we just leave it out, or leave it commented or something?

jeff-o commented 10 years ago

We could also just set it to 7 and leave it for the user to change should they need to. I'd be fine with that; what do you think?

mikepurvis commented 10 years ago

If the default is 7.5, then it doesn't make sense to re-specify that same value with a param. I think the camera.launch file should either remain unchanged, or should include a commented-out line, eg:

<!-- <param name="frame_rate" value="15" /> -->
jeff-o commented 10 years ago

Okay, that's fine with me. Leave it as 15, and comment out.