ros-drivers / pointgrey_camera_driver

ROS driver for Pt. Grey cameras, based on the official FlyCapture2 SDK.
128 stars 180 forks source link

Support for Ubuntu Yakkety, Zesty and Debian stretch #144

Closed mikaelarguedas closed 6 years ago

mikaelarguedas commented 6 years ago

Howdy @mikepurvis and pointgrey_camera_driver maintainers.

It seems that this package fails to build on Lunar on all platforms except ubuntu Xenial. At a glance it looks like the download_flycap script needs to be extended for more platforms if possible.

mikepurvis commented 6 years ago

I think the upstream SDK from the vendor only explicitly supports the Ubuntu LTS versions, but it's also an extremely large so which seems to have its dependencies bundled, so it probably would work just fine.

If we're to modify the download script with a mapping that allows it to treat all these other platforms as if they were Xenial, what should the list of them be? Based on REP 3 required+recommended and the fact that http://jenkins.ros.org/ doesn't build for Fedora, that would be yakkety, zesty, stretch, and jessie.

mikaelarguedas commented 6 years ago

Indeed we don't build binaries for fedora, so the list of platforms is the one you listed. Thanks for the quick fix!