search

ros-drivers / pointgrey_camera_driver

ROS driver for Pt. Grey cameras, based on the official FlyCapture2 SDK.
128 stars 180 forks source link

Add Option to turn off packet resend #158

Open FinnLinxxx opened 6 years ago

FinnLinxxx commented 6 years ago

According to line 896 the Flea3 GigE Camera FL3-GE-14S3C-C is an accepted GigE-Camera, but does not support "packet resend".

As there is no full support for Flea3 cameras, there might still is a need to adapt to such a condition more agile flexible.

https://github.com/ros-drivers/pointgrey_camera_driver/blob/ae5da34fabf33b25613a691b980036163d6880e5/pointgrey_camera_driver/src/PointGreyCamera.cpp#L915

FinnLinxxx commented 6 years ago

Connection to camera and ROS integration of the package was successfully tested after setting bool to false

mikepurvis commented 6 years ago

Cool, please send a PR for this change.

FinnLinxxx commented 6 years ago

Going to solve the hardwired fix made by #97

PR incomming soon, need to test with the actual camera before.

Going to append from line 822 in PointGreyCamera.cpp +++

void PointGreyCamera::setGigEParameters(bool auto_packet_size, unsigned int packet_size, unsigned int packet_delay, bool packet_resend)
{
  auto_packet_size_ = auto_packet_size;
  packet_size_ = packet_size;
  packet_delay_ = packet_delay;
  packet_resend_ = packet_resend;
}