search

ros-drivers / pointgrey_camera_driver

ROS driver for Pt. Grey cameras, based on the official FlyCapture2 SDK.
128 stars 179 forks source link

For GigE cameras, automatically discover best packet size. #16

Closed wnoise closed 9 years ago

wnoise commented 9 years ago

Tested with USB2 Chameleon and GigE Flea 3.

mikepurvis commented 9 years ago

I don't have any of the GigE devices to test with. Was the previous logic just using a default value?

wnoise commented 9 years ago

Previously it left whatever was in the camera alone. This could be the default from power on (either the factory default or one of the saved memory configurations), or whatever the last program to touch the camera put in. In practice, only 9000 or 1400 are useful values, depending on whether your hardware supports jumbo frames or not. Given this, I thought autoconfiguration was a better bet than exposing through dynamic_configure.

mikepurvis commented 9 years ago

Okay, sounds good.