search

ros-drivers / pointgrey_camera_driver

ROS driver for Pt. Grey cameras, based on the official FlyCapture2 SDK.
128 stars 180 forks source link

Add option to turn off packet resend #163

Open FinnLinxxx opened 6 years ago

FinnLinxxx commented 6 years ago

My camera (Flea3 GigE Camera FL3-GE-14S3C-C) does not work properly with the current git/master. It is not able to turn on the packet_resend option as set by #97 (hardwired) ( Issue #158 ). This PR adds the option to turn off packet resend before runtime.

ex1

cd ~/devel/lib/pointgrey_camera_driver
./camera_node _packet_resend:=false

ex2

roslaunch pointgrey_camera_driver camera.launch packet_resend:=false

true is still the default value.

Sindorman commented 6 years ago

@FinnLinxxx Would this help with issue #155 ? This PR will help us with our issue!

Sindorman commented 6 years ago

@mikepurvis Greetings, who can review and approve this pull request? This is very important change to my robosub team.

mikepurvis commented 6 years ago

@Sindorman Change looks reasonable to me. Have you validated by running the driver from source that this change improves performance for you?

Sindorman commented 6 years ago

@mikepurvis I have not. I will see if I can compile and run it. Interesting note: Flea3 GigE Camera FL3-GE-14S3C-C documentation says that Packet Resend is supported.

Sindorman commented 6 years ago

@mikepurvis We have tested the branch source code, compiled and integrated with all ROS drivers, it works well!! I think it is good to go to be merged! Cameras live test shows everything works the same as on indigo.