search

ros-drivers / pointgrey_camera_driver

ROS driver for Pt. Grey cameras, based on the official FlyCapture2 SDK.
128 stars 180 forks source link

Won't work on non-Debian systems #3

Closed cottsay closed 10 years ago

cottsay commented 10 years ago

As it stands, the pointgrey driver will only work on Debian systems because it downloads and extracts debs. Even if we change how the debs are extracted or install dpkg on non-debian systems, the executables therein are likely linked against Debian libraries, which are not always the same version on Fedora.

Instead, would it be possible to download the source for libflycapture and compile it? This would make this package work on Fedora, Arch and OSX.

cc @bchretien

mikepurvis commented 10 years ago

Unfortunately not— the source is not available, and Pt. Grey's license terms do not permit redistribution of even the headers. I've chatted with them, and they're not interested in making an exception for the ROS community.

That said, I'd be delighted if you can come up with a solution that would allow this driver to work on non-Debian systems.

cottsay commented 10 years ago

This is very disappointing to hear. I'm sorry Pt. Grey isn't willing to work with the community on this.

I'm looking into using dpkg to extract the binaries supplied by Pt. Grey. So far, this allows us to compile the driver, but I can't install it because RPM found a library dependency that isn't available (this is what I was afraid of).

I'll let you know if I find a fix for that :)

cottsay commented 10 years ago

I think we can work with adding dpkg as a build_depends and a little bit of voodoo in the packaging process. When dpkg is in rosdep, I'll attach code to do so.

Thanks,

--scott

cottsay commented 10 years ago

I've added code to build_depend on dpkg, whose deps are now in rosdep. As for the odd library dependency issues, they won't come up for source installs of this package, only RPM installs. We'll need to add an extra Provides: line to the RPM SPEC for the library that was downloaded from Pt. Grey.

Thanks for bearing with me on this one.

mikepurvis commented 10 years ago

No problem. Let me know when you'd like this merged.

cottsay commented 10 years ago

I think we can merge this as-is. This will get things up-and-running for source installs. The other fix will need to be a Bloom patch for the RPM spec...but we have a ways to go before spec generation is ready in Bloom.