search

ros-drivers / pointgrey_camera_driver

ROS driver for Pt. Grey cameras, based on the official FlyCapture2 SDK.
128 stars 179 forks source link

Add auto white balance and fix not able to write white balance #38

Closed versatran01 closed 9 years ago

versatran01 commented 9 years ago

Fix the problem of not being able to set white balance using Property. When trying to set white balance on my FL3-U3-13E4C-C, both this ros driver and flycap software cannot set the white balance naturally. After playing around with the flycap software, I found that I have to set the highest bit of register 80C (which is white balance) to 1 to enable this feature. So I modified the original SetWhiteBalance to use WriteRegister directly. And add support for auto white balance.

I currently don't have other pointgrey cameras, so I cannot verify that this will work for sure. Also, when initially launched, since the frame rate is low (7.5hz), it will some time for the auto white balance to converge to the right values. So the entire image would look green and gradually become normal.

mikepurvis commented 9 years ago

Is defaulting to true for this the correct action? That is a change in behaviour from previously, if I'm understanding it correctly.

versatran01 commented 9 years ago

The default is true, but it will fall back to false if white balance is not supported, and will reflected in the dynamic reconfigure.

mikepurvis commented 9 years ago

Okay, gonna merge this and release to Jade. If there are no complaints, it can potentially be released back to Indigo as well.