search

ros-drivers / pointgrey_camera_driver

ROS driver for Pt. Grey cameras, based on the official FlyCapture2 SDK.
128 stars 180 forks source link

Update flycap SDK to 2.10.3.169 needed for Ubuntu 16.04 #73

Closed konradb3 closed 6 years ago

konradb3 commented 7 years ago

Only tested with Ubuntu 16.04 and ROS Kinetic.

mikepurvis commented 7 years ago

Would you mind updating the Travis job to use trusty/indigo so that it passes for this change?

mikepurvis commented 7 years ago

I feel like we're have a lot of breakages and back and forth on which version of flycap to use. I suppose there's not much we can do other than upgrade and wait for screams— I certainly haven't got a full suite of PGR hardware with which to test.

konradb3 commented 7 years ago

The Travis with trusty use custom build version of Python. It breaks all python dependent deb's including catkin :disappointed:

konradb3 commented 7 years ago

I can confirm that new flycap don't work on pre16.04 ubuntu. The new libstdc++ use different ABI, so we need different binaries for new(>=16.04) and old(<16.04) ubuntus. This can be done by branching old version of driver of introducing some magic in cmake to download different flycap based on ubuntu version.

mikepurvis commented 7 years ago

Gross.

CMake magic is one way to go; alternatively, we could consider going to split indigo-devel/kinetic-devel branches in the repo, release the Kinetic branch as 0.13.0, and simply manage the change that way.

mikepurvis commented 7 years ago

Regarding Python madness, here's a build to check what's going on with Python in the Trusty build environment: https://travis-ci.org/ros-drivers/pointgrey_camera_driver/builds/147197164

Looks like it's not even installed from a debian package at all— maybe just a straight up make; make install? Either way, it seems like even under language: cpp, Travis still dumps you into a venv: https://docs.travis-ci.com/user/languages/python

EDIT: Gracious. Here's the full value of PATH:

$ echo $PATH
/home/travis/bin:/home/travis/.local/bin:/home/travis/.phpenv/shims:/home/travis/.php-build/bin:/home/travis/.gimme/versions/go1.5.1.linux.amd64/bin:/home/travis/.local/bin:/home/travis/.pyenv/shims:/opt/pyenv/bin:/opt/python/2.7.10/bin:/opt/python/3.5.0/bin:/opt/python/2.6.9/bin:/opt/python/3.2.6/bin:/opt/python/3.3.6/bin:/opt/python/3.4.3/bin:/opt/python/pypy-2.6.1/bin:/opt/python/pypy3-2.4.0/bin:/home/travis/.phpenv/shims:/usr/local/phantomjs/bin:/usr/local/phantomjs:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v4.1.2/bin:./node_modules/.bin:/usr/local/maven-3.1.1/bin:/usr/local/gradle/bin:/usr/local/clang-3.5.0/bin:/home/travis/.gimme/versions/go1.5.1.linux.amd64/bin:/home/travis/.local/bin:/usr/local/rvm/gems/ruby-2.2.3/bin:/usr/local/rvm/gems/ruby-2.2.3@global/bin:/usr/local/rvm/rubies/ruby-2.2.3/bin:/home/travis/.pyenv/shims:/opt/pyenv/bin:/opt/python/2.7.10/bin:/opt/python/3.5.0/bin:/opt/python/2.6.9/bin:/opt/python/3.2.6/bin:/opt/python/3.3.6/bin:/opt/python/3.4.3/bin:/opt/python/pypy-2.6.1/bin:/opt/python/pypy3-2.4.0/bin:/home/travis/.phpenv/shims:/usr/local/phantomjs/bin:/usr/local/phantomjs:./node_modules/.bin:/usr/local/maven-3.1.1/bin:/usr/local/gradle/bin:/usr/local/clang-3.5.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/home/travis/.phpenv/bin:/usr/local/rvm/bin:/home/travis/.phpenv/bin

So the obvious thing to would be blow away all of this madness and hard-set PATH to /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin.

kev-the-dev commented 7 years ago

@konradb3 Do you have any documentation that says 16.04 is only compatible with flycap SDK 2.10? We're running a submarine with 3 pointgrey cameras using this driver and are having some miscellaneous issues and are wondering if the sdk version might be the problem.

konradb3 commented 7 years ago

@ironmig On the ptgray (FLIR) website there are two versions of the SDK available for download :

Addition of Ubuntu 16.04 support is probably mentioned in 2.11 release note.

tedchina commented 7 years ago

@ironmig @konradb3 I onced tried FlyCapture 2.11.3.121 SDK on Intel Joule with Ubuntu 16.04, the flycap launch was successful but the app window would crash whenever I attempted to turn on the camera. I reported this to FLIR and they confirmed some bug and to release a new version soon. Before a new release, I was using an older version flycapture2-2.10.3.266-amd64-pkg.tgz, with which this ROS driver can also work successfully (with a re-make).

mikepurvis commented 6 years ago

Covered by #127. Thanks all.