search

ros-drivers / pointgrey_camera_driver

ROS driver for Pt. Grey cameras, based on the official FlyCapture2 SDK.
128 stars 180 forks source link

Adding string parameter fallback. #81

Closed mikeodr closed 7 years ago

mikeodr commented 7 years ago

Adding serial parameter for the camera to fallback to reading as a string.

mikeodr commented 7 years ago

@mikepurvis FYI.

mikepurvis commented 7 years ago

I wonder what happens if you read an int parameter as a string? Like, could we just switch this to string without the fallback?

efernandez commented 7 years ago

This should be done using the XmlRpc types from the param, similar to how footprints can be vectors or strings in navigation: https://github.com/ros-planning/navigation/blob/0fec250ead4a8b2c5ed2e6d1e3efb28e7885c12e/costmap_2d/src/footprint.cpp#L220

mikeodr commented 7 years ago

Sure thing @efernandez will update in due course

mikeodr commented 7 years ago

Updated with @efernandez suggestion

mikepurvis commented 7 years ago

LGTM